Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): add onClick prop #75

Merged
merged 1 commit into from
Dec 14, 2023
Merged

feat(components): add onClick prop #75

merged 1 commit into from
Dec 14, 2023

Conversation

mnlfischer
Copy link
Contributor

Description

Add onClick prop to navigations popover item to support custom behavior for navigation items.

Checklist

  • Change increases quality
  • Change is validated by tests
  • Change is readable and easy to understand
  • Documentation is updated
  • Security impact has been considered
  • Changes validated in runtime

@linear Linear
Copy link

linear bot commented Dec 14, 2023

PLA-899 Add onClick to Popover button

pallendes
pallendes approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@pallendes pallendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnlfischer mnlfischer merged commit d40d99b into main Dec 14, 2023
6 checks passed
@mnlfischer mnlfischer deleted the pla-899-add-onclick-to-popover-button branch December 14, 2023 12:26
@abusix-bot
Copy link
Collaborator

🎉 This PR is included in version 3.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juliana-CBB Juliana-CBB Juliana-CBB approved these changes

@pallendes pallendes pallendes approved these changes

Assignees

@mnlfischer mnlfischer

Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mnlfischer @abusix-bot @pallendes @Juliana-CBB